Open
Conversation
Collaborator
|
@cosandr Hi! Thx for this PR. When migrating modules from ceph-ansible project(1), sanity check failed as best practices require to move state: info, list (2) into separate modules called _info. Looks like I removed list from the ceph_pool module but forgot to create a ceph_pool_info.py module. Either you can do it or just open an issue and I'll do it later. (1) #3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes
listnot being allowed by theceph_poolmodule, despite being implemented.I've also fixed a crash caused by an extra parameter being passed.
The
nameparameter isn't required forlist(neither is it being used), so only make it required if state is notlist.